C++ 98 requires all source files to terminate with a new-line character.
It also does not allow for semicolons outside of declarations that
require it (and in function scopes). Fix them to allow for pedantic
warnings to be enabled when beneficial. Finally, it does not allow for
object-to-function casts.

The first two warnings are resolved trivially. For the third, the
solution to cast through a pointer address is technically unsafe, as
systems are not required to support object pointers (e.g. void *)
being able to represent function pointers. However, the existence of
dlsym() virtually implies this is supported on the target system
(technically, all symbols could be data symbols, but that is
nitpicking).

Stochastic guards are supposed to be generated in a way that the if
branches are disjoint and exhaustive. Compilers have trouble verifying
the latter property, as they usually do not pick up postconditions on
return value of myrand(0, 99).

To silence warnings regarded control paths that do not return a value,
and to add hardening against code generation bugs that actually violate
exhaustion of the if branches, assert() and abort() at the end of such
functions.

Commit f1db3a0a adjusted
ActionFuncPointer to generally return a delay. However, this is only
done for TMLDelayAction generation, leaving the other producers of
ActionFuncPointer emitting functions without a return value despite the
changed return type.

To address this, distinguish between ActionFuncPointer and
DelayActionFuncPointer.

Arrays of length 0 yield implementation-defined behaviour, which causes
a compiler warning. In C, this was typically used to model
flexibly-sized array members trailing a struct. Here, length 0 actually
means it occupies no storage.

Hence, do not emit the _channels array when it would otherwise have a
length of 0.

Marvin Häuser authored 1 year ago and Marvin Häuser committed 1 year ago

Currently, terminal support is broken on macOS and Linux on AARCH64,
because JNA 3.3.0 does not support this architecture. Update the library
to the latest version, which supports AARCH64 and enables terminal
support.

This reverts merge request !471

Marvin Häuser authored 1 year ago and Marvin Häuser committed 1 year ago

Currently, terminal support is broken on macOS and Linux on AARCH64,
because JNA 3.3.0 does not support this architecture. Update the library
to the latest version, which supports AARCH64 and enables terminal
support.