The final() macro used for hashing overrides the language keyword final,
which may cause compilation issues for otherwise valid code. Rename it
to resolve the collision.

Extra compiler warnings include signedness mismatches of comparison
operations, as the implicit type promotion may unexpectedly convert
negative values and thus skew the result. Adjust the affected signed
types to unsigned types, as the corresponding values cannot be negative
anyway.

The character '<' does not have any functional meaning and thus cannot
be escaped.

Some operations to insert or remove samples may leave their return value
uninitialized under exceptional conditions. Return 0 in these cases to
indicate to samples were inserted or removed.

oLastTrans may be NULL when saving the benchmark to file. The current
logic does not handle this correctly, dereferencing it for a print.
Print a dummy value when the variable is NULL to resolve the issue.

Simulator::simulate() should guarantee its argument oLastTrans is
initialized when it returns. However, not all code paths currently do
so. To resolve the issue, initialize it to NULL in the beginning.

The current logic calls va_arg() once after the actual last argument has
been retrieved. While this should usually not cause real-world problems,
it is undefined behaviour caught by AddressSanitizer.

JNA: Update to 5.13.0 for ARM compatibility v2

See merge request !474

Pattern generation

See merge request !476

Pattern generation

See merge request !475

Marvin Häuser authored 1 year ago and Marvin Häuser committed 1 year ago

Currently, terminal support is broken on macOS and Linux on AARCH64,
because JNA 3.3.0 does not support this architecture. Update the library
to the latest version, which supports AARCH64 and enables terminal
support.

Pattern handling

See merge request !472

Revert "Merge branch 'jna_update' into 'master'"

See merge request !473

This reverts merge request !471

JNA: Update to 5.13.0 for ARM compatibility

See merge request !471